refactor: switch database to document-based #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyhippari
force-pushed
the
refactor-change-database
branch
from
df812d1
to
6776f5c
Compare
|
Closing this, as it seems like clover has issues with doing updates in goroutines... It might be me not being proficient enough with Go, though, so I'm leaving the branch there, just in case someone who knows how to fix this stumbles on the repo. |
|
Turns out this is exactly what Mutexes are for. Who knew? Good thing I didn't delete the branch. This is still on the table, so reopening. Can you tell I'm a frontend engineer and don't do backend work all that often? 😄 |
heyhippari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relational database isn't really suited for what I want to do here. And with the lack of graph databases you can embed, a document-based one seems like a better fit.
So this switches the entire database layer to use clover, which seems like a decent (If somewhat new and bare-bones in terms of features) embeddable database.
If this proves to be "not enough" at some point, the current structures makes it pretty easy to change which kind of database we're using, and we can always go "lower level" if we need to, with something like goleveldb, bbolt or something.
This PR also reworks the Sentry integration a little, mainly by properly deferring a flush (So if a crash happens, we still get whatever Sentry needs to send before the program exits) and by adding a config option to opt out of crash reporting.