Permalink
Browse files

Sanitize GROUP BY etc. as well

  • Loading branch information...
1 parent 7490916 commit 3845a2c6f6df9cb22a7f29bd90ccb4ed9ce4c987 @methodmissing committed Mar 15, 2009
Showing with 2 additions and 2 deletions.
  1. +1 −1 README.textile
  2. +1 −1 lib/optimizations/columns/macro.rb
View
@@ -214,7 +214,7 @@ h2. Todo
* Deeper coverage for Scrooge::AttributesProxy ( pending conversion to a subclass of Hash instead )
-* Extract Scrooge::Callsite
+* Test cases for Scrooge::Callsite
* Track both columns AND association invocations off Scrooge::Callsite
@@ -28,7 +28,7 @@ module SingletonMethods
ScroogeBlankString = "".freeze
ScroogeComma = ",".freeze
- ScroogeRegexSanitize = /(?:LIMIT|WHERE).*/i
+ ScroogeRegexSanitize = /(?:LIMIT|WHERE|FROM|GROUP\s*BY|HAVING|ORDER\s*BY|PROCEDURE|FOR\s*UPDATE|INTO\s*OUTFILE).*/i
ScroogeRegexJoin = /(?:left|inner|outer|cross)*\s*(?:straight_join|join)/i
@@scrooge_select_regexes = {}

0 comments on commit 3845a2c

Please sign in to comment.