From 864bb1948af2337eff970be9cbab6275240e13f4 Mon Sep 17 00:00:00 2001
From: David Seguin <david.seguin@gmail.com>
Date: Wed, 13 Jul 2022 11:19:52 -0400
Subject: [PATCH] adjust banners

---
 src/base/_sizes.scss              | 14 ++++++++++----
 src/components/alert/alert.scss   |  4 ++--
 src/components/banner/banner.scss |  2 +-
 3 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/base/_sizes.scss b/src/base/_sizes.scss
index 61340dbf..8c972d1f 100644
--- a/src/base/_sizes.scss
+++ b/src/base/_sizes.scss
@@ -23,9 +23,9 @@ $bp-extra-large: $bp-1440;
 $bp-audio-player: 600px;
 
 //padding and margins
-//This is used super sparingly and won't be a part of most designs.
-$spacing-micro: calc(8px + 0.25vw);
 
+//"hard-sh" pixel based with some leeway for viewport widths
+$spacing-micro: calc(8px + 0.25vw);
 $spacing-xxs: calc(16px + 0.5vw);
 $spacing-xs: calc(24px + 0.75vw);
 $spacing-s: calc(32px + 1vw);
@@ -34,19 +34,25 @@ $spacing-l: calc(64px + 2vw);
 $spacing-xl: calc(98px + 6vw);
 $spacing-xxl: calc(144px + 9vw);
 
+//"soft" purely based on viewport vidth
+$spacing-soft-m: 7.5vw; //DS - formerly $spacing-component-margin
+
 //I know, i know, this is clunky. We need a negative margin for the Jumplink Banner,
 //TODO: find a better way to do this.
 $spacing-negative-micro: calc(-1 * (8px + 0.25vw));
 
-//absolute max width for productive component
+//absolute, hard max width for productive component
 $max-component-size: 1000px;
 
 //ideal width for priductive component, with a cross-browser scrollbar adjustment
 $width--scrollbar-agnostic: calc(85vw - (100vw - 100%));
 
-//calculation for productive component - the width--scrollbar-agnostic up to the max-size
+//calculation for productive component - it's width--scrollbar-agnostic up to the max-size
 $productive-width-max: clamp(0px, #{$width--scrollbar-agnostic}, #{$max-component-size});
 
+//when the above calculation can't be used, this is a close substitute
+$faux-productive-width-max: 85vw;
+
 //the calculation for an offset margin of the component
 $spacing-component-margin: calc((100vw - #{$productive-width-max})/2);
 
diff --git a/src/components/alert/alert.scss b/src/components/alert/alert.scss
index 22c5ac80..30237169 100644
--- a/src/components/alert/alert.scss
+++ b/src/components/alert/alert.scss
@@ -7,12 +7,12 @@
 	font-size: $textsize-xs;
 	font-weight: 500;
 	justify-content: space-between;
-	left: 7.5vw;
+	left: $spacing-soft-m;
 	line-height: 1;
 	padding: $spacing-micro;
 	position: fixed;
 	top: $spacing-s;
-	width: 85vw;
+	width: $faux-productive-width-max;
 
 	&.show {
 		display: flex;
diff --git a/src/components/banner/banner.scss b/src/components/banner/banner.scss
index 0ed4ae9c..745412a5 100644
--- a/src/components/banner/banner.scss
+++ b/src/components/banner/banner.scss
@@ -70,7 +70,7 @@
 	align-items: center;
 	display: flex;
 	justify-content: center;
-	padding: $spacing-m $spacing-component-margin;
+	padding: $spacing-m $spacing-soft-m;
 	@media (orientation: portrait) {
 		min-height: 50vw;
 	}