rose edit: tweak latent page display #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewrmshin, please review. |
| @@ -544,6 +546,23 @@ def expand_recursive(self, start_path=None, no_duplicates=False): | |||
| if path != start_path: | |||
| stack.append(treemodel.iter_next(iter_)) | |||
|
|
|||
| def _get_is_latent_sub_tree(self, model, iter_): | |||
| """Return True if the whole model sub tree is latent.""" | |||
| if not model.get_value(iter_, 8): | |||
There was a problem hiding this comment.
Can 8 be a constant of the class?
|
Updated vs feedback. |
matthewrmshin
added a commit
that referenced
this pull request
Jun 11, 2014
…atent rose edit: tweak latent page display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, a page is always displayed regardless of
View Latent Pagesstatus if it has no relevant sectionsor if it has sub-pages. This functionality guards against
having pages such as the
namelistpage appear as alatent page (greyed out) and similarly for the parent page
for a group of duplicate sections.
However, this leads to a lot of irrelevant, undesirable pages
appearing by default in some configurations. For example,
every duplicate section will appear as a non-latent page (
see the example in the demo_meta suite below).
The best logic is to say that all pages that are parents of
non-latent pages must be displayed as non-latent. Every
other page with no content can then be described as latent
and hidden correctly.