rosie go: improve new suite wizard behaviour. #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a larger, maximizable window for editing the suite info data (access-list, title, etc). It also makes sure that the project metadata is correctly loaded for extra compulsory variable addition. The metadata for our standard rose-suite.info options has also been improved.
| @@ -40,7 +40,7 @@ help=Specify a space-separated list of ticket/issue ids. | |||
| = #32 #45 | |||
|
|
|||
| [=opts] | |||
| description=A space-delimited list of optional configuration keys to switch on. | |||
| description=A space-delimited list of opt conf keys to switch on. | |||
There was a problem hiding this comment.
Think I preferred the original expanded version of this since it is effectively documentation.
There was a problem hiding this comment.
It's too long for a description - it pushes the buttons etc too far to the right.
|
Looks good to me. Works as expected with the demo metadata available. Just those two comments. |
|
@benfitzpatrick - bump. |
|
@benfitzpatrick - bump. |
|
Looks good to me. Manually testing out as working. |
arjclark
added a commit
that referenced
this pull request
Aug 8, 2014
…d-tweaks rosie go: improve new suite wizard behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a larger, maximizable window for editing the
suite info data (access-list, title, etc). It also makes
sure that the project metadata is correctly loaded for
extra compulsory variable addition, and that changes
in the edit window do not persist when going back
and changing the project.
The metadata for our standard rose-suite.info options has
also been improved.
@arjclark, please review.