Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose metadata: fail-if: better syntax error #1436

Merged

Conversation

benfitzpatrick
Copy link
Contributor

This closes #1218.

@kaday, please review.

@benfitzpatrick benfitzpatrick added this to the next-release milestone Oct 14, 2014
@kaday
Copy link
Contributor

kaday commented Oct 16, 2014

Passes the test battery in my environment.
Syntax error is improved for the fail-if.
Pylint score improved compared to master and PEP8 the same.

kaday added a commit that referenced this pull request Oct 16, 2014
…ax-errors

rose metadata: fail-if: better syntax error
@kaday kaday merged commit c6a7d72 into metomi:master Oct 16, 2014
@benfitzpatrick benfitzpatrick deleted the 1218.better-fail-if-syntax-errors branch March 16, 2015 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rose metadata: more informative fail-if/warn-if tracebacks
2 participants