use cylc sphinx extensions repo #2374
Conversation
|
|
oliver-sanders
force-pushed
the
migrate-cylc-tutorial
branch
from
5b7c0ac
to
5935c5e
Compare
oliver-sanders
force-pushed
the
migrate-cylc-tutorial
branch
from
5935c5e
to
cd7e68e
Compare
| 'cylc-sphinx-extensions' | ||
| ' @ ' | ||
| 'git+https://github.com/cylc/cylc-sphinx-extensions.git' | ||
| '#egg=metomi_rose[all]' |
There was a problem hiding this comment.
Install direct from GitHub for now, see also cylc/cylc-sphinx-extensions#3
oliver-sanders
changed the title
There was a problem hiding this comment.
Otherwise looks good & builds successfully, however I got a set of corresponding build warnings relating to finding resources from the installed cylc-sphinx-extensions repo (see sub-comment) which should be addressed.
We should also update the 'Documentation builder' specification for rose check-software accordingly, for example to include cylc-sphinx-extensions (unless we plan to deprecate that command, I have no idea about the plans for it?), though that could be a follow-on PR?
There was a problem hiding this comment.
Feedback addressed; resolved when the branch from cylc/cylc-sphinx-extensions#7 response PR is used (I will merge that one now too).
|
(Two approvals is standard, & @wxtim is on leave anyway so it would be days before any feedback from him, so it is safe & pragmatic to merge now.) |
Remove cylc tutorial (it is in cylc-doc now)