Fix cat{n} unparser with invalid value #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reduce-kv calls need to short-circuit on ::m/invalid. Discovered by Typed Clojure.
|
thanks! |
respatialized
added a commit
to respatialized/respatialized
that referenced
this pull request
Apr 20, 2022
The use of malli.core/unparse seems to have been affected by the bug fixed in metosin/malli#690. Bumping to the latest SHA allows for the definition of parsers/unparsers that allow for correct bidirectional conversion. This will make things substantially easier going forward. Once a fix lands in a tagged release of malli, these parsers/unparsers should probably be pushed upstream to Fabricate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reduce-kv calls need to short-circuit on ::m/invalid.
Discovered by Typed Clojure.