New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure(Script) support for muuntaja #7

Open
ikitommi opened this Issue Sep 19, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@ikitommi
Copy link
Member

ikitommi commented Sep 19, 2016

Negotiating formats should be symmetric, on both server & client. Also for ClojureSript. Should run on Node too.

@ikitommi ikitommi added the help wanted label Oct 7, 2016

@ikitommi ikitommi changed the title Clojure(Script) client for muuntaja Clojure(Script) support for muuntaja Dec 15, 2016

@Nolan330

This comment has been minimized.

Copy link

Nolan330 commented Aug 12, 2018

Hey @ikitommi, curious if this is still relevant and open for PRs, and if this port would make the muuntaja middleware usable from node as well e.g. in macchiato/reitit.

happy to help if possible! where would you point someone looking to get started?

@ikitommi

This comment has been minimized.

Copy link
Member Author

ikitommi commented Aug 12, 2018

PR for this would be most welcome!

I think most of the code should map nicely from clj to cljc. The major differences are that muuntaja.format.json should use js/JSON instead of Jsonista, exception handling might have different types and return types (steams, bytes) might need to work differently.

For the JSON format, the macchiato code might help.

When all the tests work both on the CLJ & CLJS, I think it's mostly done.

There is a working cljs tests setup in https://github.com/metosin/reitit, to run locally & in the CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment