Skip to content

Fix {required,optional}-keys regression - #59

Merged
ikitommi merged 1 commit into
metosin:masterfrom
frenchy64:optional-keys-regression
Jan 30, 2020
Merged

ikitommi merged 1 commit into
metosin:masterfrom
frenchy64:optional-keys-regression

Conversation

@frenchy64

@frenchy64 frenchy64 commented Jan 30, 2020 •

Copy link
Copy Markdown
Contributor

{required,optional}-keys used to support string keys by
coincidence of its implementation. The implementation was
changed to share code with optional-keys-schema -- the current
commit restores 0.10.2 behavior for {required,optional}-keys
while preserving optional-keys-schema's behavior.

Regression introduced in [metosin/schema-tools "0.10.3"]
(b3d63fc).

{required,optional}-keys used to support string keys by
coincidence of its implementation. The implementation was
changed to share code with optional-keys-schema -- the current
commit restores 0.10.2 behavior for {required,optional}-keys
while preserving optional-keys-schema's behavior.

Regression introduced in [metosin/schema-tools "0.10.3"]
(sha: b3d63f).
@ikitommi
ikitommi merged commit 3d2cc4b into metosin:master Jan 30, 2020
@ikitommi

Copy link
Copy Markdown
Member

Thanks! released [metosin/schema-tools "0.12.2"] with just this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants