Code coverage is different for text and html rcov formatter in metric_fu

[crv]

One other thing which I observed with Rcov in metric_fu is ... If I try to find coverage using the simplecov text formatter and HTML formatter then there is a difference.

I tried to find out the reason why it happens, I found that

If you have method e.g.

class A
  def m(arg1)
    p "this is my method" # Assume that none of the line covered in this method
    if arg1 > 5
        p 'more than 5'
    else
       p 'not more than 5'
    end 
  end 
end 

As per HTML format, the code coverage percent is 2/7 = 0.28 (28% - 7 relevant lines, 2 lines covered 5 lines missed)
As per the text format the code coverage percent is 5/10 = 0.5 (50% - 10 relevant lines, 5 lines covered 5 lines missed)

This is weird. The reason here is text format takes last 3 end statements into the consideration while HTML formatter ignores it.

[bf4]

@crv Do I understand you that the simplecov-rcov-text formatter gives different results than the default simplecov formatter?

How are you running the coverage metric? Can you paste the output of metric_fu --debug-info?

[bf4]

We should really either implement our own simplecov formatter or finally just abandon an semblance of rcov. Either way, such a PR would be control of coverage back in the hands of metric_fu. Also see #156 where the coverage metric will be run if the external file is found; rather than if it is configured.

[bf4]

In any case, thanks for adding a test case, here. I've started spiking out an internal MetricFu formatter #201

[bf4]

I finally got around to writing this test, and the numbers appear to be 4/7 for both. Did you test this differently or perhaps the bug went away?

https://github.com/metricfu/metric_fu/tree/fix_coverage