Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale pk2iv model has wrong scaling volume #833

Closed
kylebaron opened this issue May 19, 2021 · 1 comment · Fixed by #832
Closed

Scale pk2iv model has wrong scaling volume #833

kylebaron opened this issue May 19, 2021 · 1 comment · Fixed by #832
Assignees
@kylebaron
Labels
bug low-risk
Projects
Development
Milestone
v0.11.2

Comments

@kylebaron
Copy link
Collaborator

Summary

As a user, I want CENT to be scaled by V1 in pk2iv.cpp

Tests

  • tests/testthat/test-modlib.R
    • pk2iv uses V1 to scale CENT
@kylebaron
Copy link
Collaborator Author

See #832 #831

@kylebaron kylebaron self-assigned this May 19, 2021
@kylebaron kylebaron added this to the v0.11.2 milestone May 19, 2021
@kylebaron kylebaron added this to Evaluate in Development May 19, 2021
@kylebaron kylebaron mentioned this issue May 19, 2021
Closed
Development automation moved this from Evaluate to Done Jul 15, 2021
@kylebaron kylebaron linked a pull request Jul 15, 2021 that will close this issue
Scale cent by v1 not v2 in pk2iv #832
Merged
@kylebaron kylebaron mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylebaron kylebaron

Labels
bug low-risk
Projects
Development
  
Done
Milestone
v0.11.2
Development

Successfully merging a pull request may close this issue.

Scale cent by v1 not v2 in pk2iv metrumresearchgroup/mrgsolve
1 participant
@kylebaron