Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm Integration #3

Merged
merged 6 commits into from Oct 13, 2020
Merged

Psalm Integration #3

merged 6 commits into from Oct 13, 2020

Conversation

diwms
Copy link
Contributor

@diwms diwms commented Oct 5, 2020

Hi there 馃憢馃徎
I'm trying to contribute and close issue #1

I've no idea what I need to write in the issue template since this is an attempt to close the existing issue 馃槃

Please, let me know what do you think guys 馃憤馃徎

Happy Hacktoberfest! 馃

@boesing boesing added this to To do in Psalm via automation Oct 5, 2020
@boesing boesing added Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 5, 2020
@boesing boesing linked an issue Oct 5, 2020 that may be closed by this pull request
8 tasks
composer.json Outdated Show resolved Hide resolved
src/BasicAccessFactory.php Show resolved Hide resolved
src/BasicAccessFactory.php Show resolved Hide resolved
src/BasicAccessFactory.php Show resolved Hide resolved
test/BasicAccessFactoryTest.php Outdated Show resolved Hide resolved
test/BasicAccessTest.php Outdated Show resolved Hide resolved
@diwms diwms requested a review from boesing October 6, 2020 09:48
@diwms
Copy link
Contributor Author

diwms commented Oct 6, 2020

@boesing I believe all these issues with annotations can be fixed by upgrading phpunit to 9 version.
Psalm plugin then should better understand what is going on and not complaint about types and methods on prophecy mocks.

Can I also include this upgrade in this PR and close #2 as well ?
Or it's better to start a new branch with PHP 8 support and then come back to this PR?

@geerteltink
Copy link
Contributor

Can I also include this upgrade in this PR and close #2 as well ?
Or it's better to start a new branch with PHP 8 support and then come back to this PR?

Please create a new PR for #2. In there you change the PHP constraints and upgrade phpunit.

@Ocramius
Copy link
Member

Ocramius commented Oct 7, 2020

@diwms I guess we wait for #4 to be merged, before working on this further? Once we have PHPUnit 9, we get better type inference too \o/

Fixes #1

Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Revert code back to inline invocations
Add phpunit cache to gitignore

Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Signed-off-by: Myroslav Zozulia <admin@diwms.com>
@diwms diwms requested a review from Ocramius October 13, 2020 11:06
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@Ocramius Ocramius added this to the 1.1.0 milestone Oct 13, 2020
@Ocramius Ocramius self-assigned this Oct 13, 2020
@Ocramius Ocramius merged commit e915793 into mezzio:1.1.x Oct 13, 2020
Psalm automation moved this from To do to Done Oct 13, 2020
@Ocramius
Copy link
Member

Excellent work, thank you, @diwms!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
Psalm
  
Done
Development

Successfully merging this pull request may close these issues.

Psalm integration
4 participants