Add PHP8 support #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseparovic1
force-pushed
the
introduce-support-for-php8
branch
from
0de7098
to
7e54adf
Compare
Signed-off-by: Jurica Šeparović <jurica.separovic@gmail.com>
jseparovic1
force-pushed
the
introduce-support-for-php8
branch
from
b94eca9
to
fb7ad0d
Compare
froschdesign
added
Enhancement
Xerkus
requested changes
Oct 25, 2020
Xerkus
approved these changes
Nov 2, 2020
| env: | ||
| - DEPS=latest | ||
| - php: 7.4 | ||
| - php: nightly |
| env: | ||
| - DEPS=lowest | ||
| - php: 7.4 | ||
| - COMPOSER_ARGS="--no-interaction --ignore-platform-reqs" | ||
| - php: nightly |
| env: | ||
| - DEPS=lowest | ||
| - php: 7.4 | ||
| - COMPOSER_ARGS="--no-interaction --ignore-platform-reqs" |
| env: | ||
| - DEPS=latest | ||
| - COMPOSER_ARGS="--no-interaction --ignore-platform-reqs" |
|
@jseparovic1 It may be that the Travis is no longer running and thus the last changes are useless. But I hope it works again for this one pull request. Thank you for your patience and help! 👍 |
|
Already fixed with #8 Thank you for your time and this contribution anyway! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5
composer.jsonto provide support for PHP 8.0 by adding the constraint~8.0.0composer.jsonto drop support for PHP less than 7.3composer.jsonto implement phpunit 9.3 which supports PHP 7.3+.travis.ymlto ignore platform requirements when installing composer dependencies (simply add--ignore-platform-reqstoCOMPOSER_ARGSenv variable).travis.ymlto add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)