Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the STRUMPACK sparse direct solver and preconditioner [strumpack-dev] #222

Merged
merged 12 commits into from
Jul 7, 2017
Merged

Support for the STRUMPACK sparse direct solver and preconditioner [strumpack-dev] #222

merged 12 commits into from
Jul 7, 2017

Conversation

pghysels
Copy link
Contributor

@pghysels pghysels commented Jun 14, 2017 •
edited by tzanio
Loading

Pull request for comments about the integration of strumpack-dev into master.

  • For STRUMPACK, see: https://github.com/pghysels/STRUMPACK.
  • Look in example_build.sh and INSTALL.txt for installation instructions.
  • This branch requires metis, scotch, parmetis, ptscotch, blas, lapack, scalapack.

Test with the new Example 18p:

mpirun -np 4 ex18p -m ../data/square-disc.mesh --strumpack

TODO

pghysels and others added 4 commits June 6, 2017 21:54
@pghysels
Initial commit for STRUMPACK support in MFEM.
27cdf66
@pghysels
Add a number of routines to the STRUMPACKSolver class
a81eb2d 
to set STRUMPACK solver options.

Pass the command line arguments to STRUMPACK.
Remove some debugging statements.
Make the indentation more consistent.
@mlstowell
Build system changes to support STRUMPACK when using "make config" ra…
a6b42ea 
…ther than "cmake"
@mlstowell
Cleaning up unused variable warning and adding size checks
a020352
@tzanio tzanio requested a review from v-dobrev June 14, 2017 19:24
@tzanio tzanio changed the title Strumpack dev Support for the STRUMPACK sparse direct solver and preconditioner [strumpack-dev] Jun 14, 2017
tzanio
tzanio reviewed Jun 14, 2017
View reviewed changes
examples/ex18p.cpp Outdated
@@ -0,0 +1,328 @@
// MFEM Example 18 - Parallel Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be best if we add the --strumpack option to ex11p instead of having a separate example. Can we do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can do that. Will do it soon.

@tzanio tzanio mentioned this pull request Jun 15, 2017
Closed
@tzanio
Copy link
Member

tzanio commented Jun 28, 2017

@pghysels, can you check the edits in the INSTALL and CHANGELOG files as well as this PR for updating the documentation? (Feel free to change anything as you see fit.)

I'd like to try to merge this today if possible. @mlstowell, @v-dobrev -- Any objections?

@pghysels
Copy link
Contributor Author

STRUMPACK also depends on ParMetis and Metis.
In defaults.mk STRUMPACK_LIB includes SCOTCH_LIB and SCALAPACK_LIB, but not METIS_LIB. In defaults.mk, SUPERLU_LIB also does not depend include the ParMetis library. But in defaults.cmake, ParMETIS is listed as a requirement for SuperLUDist.

In INSTALL, it says that "STRUMPACK requires the PT-Scotch and Scalapack libraries." But STRUMPACK also requires ParMetis and Metis, just like SuperLUDist.
I just want to make sure you are aware of the dependency of STRUMPACK on (Par)METIS.

@tzanio
Copy link
Member

tzanio commented Jun 28, 2017

@pghysels: ParMetis issues fixed in db368dd?

mlstowell
mlstowell reviewed Jun 28, 2017
View reviewed changes
Copy link
Member

@mlstowell mlstowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me. Thanks for the new solver!

@tzanio tzanio added the in-next label Jun 28, 2017
@tzanio
Copy link
Member

tzanio commented Jun 28, 2017

Merged in the next branch for testing. Thanks @pghysels and @xiaoyeli!

@tzanio tzanio merged commit 5b0ab29 into master Jul 7, 2017
@tzanio tzanio deleted the strumpack-dev branch July 7, 2017 00:54
@tzanio tzanio added this to the Next release milestone Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlstowell mlstowell mlstowell left review comments

@tzanio tzanio tzanio approved these changes

@v-dobrev v-dobrev Awaiting requested review from v-dobrev

Assignees

@pghysels pghysels

Labels
enhancement in-next linalg
Projects
None yet
Milestone
mfem-3.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pghysels @tzanio @mlstowell