Fix #104: memory leak in poll_batch #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
reviewed
Jul 25, 2018
| vector<rd_kafka_message_t*> raw_messages(max_batch_size); | ||
| rd_kafka_queue_t* queue = rd_kafka_queue_get_consumer(get_handle()); | ||
| ssize_t result = rd_kafka_consume_batch_queue(queue, timeout.count(), raw_messages.data(), | ||
| Queue queue(get_queue(rd_kafka_queue_get_consumer(get_handle()))); |
There was a problem hiding this comment.
This won't actually fix the issue if someone's using rdkafka version < 0.11.5 (see the comment on get_queue). Maybe it's worth adding a comment saying that right above this line? e.g. "Note that this will leak the queue when using rdkafka < 0.11.5 (see get_queue comment)`.
There was a problem hiding this comment.
Squashed the comment to the same commit:
#107
poll_batch currently leaks memory while initialising the queue returned by rd_kafka_queue_get_consumer. The fix as suggested by @mfontanini as done here is to initialise the queue with a Queue so it's cleaned up when going out of scope.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll_batch currently leaks memory while initialising the queue
returned by rd_kafka_queue_get_consumer. The fix as suggested
by @mfontanini as done here is to initialise the queue with a
Queue so it's cleaned up when going out of scope.