New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added template files and view logic for breadcrumbs, which can be use… #110

Merged
merged 2 commits into from Oct 25, 2015

Conversation

Projects
None yet
3 participants
@aszepieniec

aszepieniec commented Aug 18, 2015

…ful for wikis with a hierarchical structure

feature can be activated by setting WALIKI_BREADCRUMBS to True in waliki/settings.py

Alan Szepieniec
added template files and view logic for breadcrumbs, which can be use…
…ful for wikis with a hierarchical structure

feature can be activated  by setting WALIKI_BREADCRUMBS to True in waliki/settings.py
@mgaitan

This comment has been minimized.

Owner

mgaitan commented Aug 19, 2015

wonderful contribution, thank you!

My first daughter was born few weeks ago and that, obviously, take me away of github and my open source projects, but let me few days to get back and I'll merge it.

PS: if you can catch what's breaking travis in all the PR, I would be very pleased to know it.

@aszepieniec

This comment has been minimized.

aszepieniec commented Aug 19, 2015

Glad you appreciate it. Unfortunately, I have no idea what's breaking travis or even how to start figuring out. Have fun with your daughter ;)

@RobertoMaurizzi

This comment has been minimized.

RobertoMaurizzi commented Aug 20, 2015

I looks like you're including a wrong version of Hovercraft: it says "Hovercraft requires Python 3.2 or higher."
Since the pull request doesn't change requirements.txt it's innocent, it's likely that something changed in Hovercraft's pypi version.
I seem to remember having similar problems with Hovercraft when I installed my test setup a while ago, unfortunately I didn't have any time to better study Waliki for the past few weeks :-/

edit: it looks like Hovercraft never supported Python 2, so this test should have failed since January 3 2015, when commit 70e5c58 added hovercraft>=1.1 to requirements-test.txt :-)

@RobertoMaurizzi

This comment has been minimized.

RobertoMaurizzi commented Aug 23, 2015

More on the topic of @aszepieniec's pull request, shouldn't waliki/settings.py change be like this?

-WALIKI_BREADCRUMBS = False
+WALIKI_BREADCRUMBS = getattr(settings, 'WALIKI_BREADCRUMBS', False)

If I don't do this, WALIKI_BREADCRUMBS = True in my settings.py gets overridden to False.

@aszepieniec

This comment has been minimized.

aszepieniec commented Aug 23, 2015

RobertoMaurizzi: Yeah, that makes a lot more sense. There's no reason this configuration variable should be defined differently from all the other ones.

Forgive me, I'm still learning.

@mgaitan mgaitan merged commit 0ce3194 into mgaitan:master Oct 25, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@mgaitan

This comment has been minimized.

Owner

mgaitan commented Oct 25, 2015

Thanks @aszepieniec , I've just merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment