New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run git with output to pipe instead of virtual terminal. #111

Merged
merged 1 commit into from Oct 25, 2015

Conversation

Projects
None yet
2 participants
@OlegGirko

OlegGirko commented Sep 10, 2015

Default SELinux policy (at least, on Fedora) doesn't allow processes running from Apache HTTP server to create virtual terminals.
By default, sh Python module runs processes with output to virtual terminal.
This is not needed for git, so it's better to explicitly make it write its output to a pipe instead of virtual terminal.

Also, --no-pager option and output through a pipe added to git tests.

Oleg Girko
Run git with output to pipe instead of virtual terminal.
Default SELinux policy (at least, on Fedora) doesn't allow processes
running from Apache HTTP server to create virtual terminals.

By default, sh Python module runs processes with output to virtual terminal.
This is not needed for git, so it's better to explicitly make it
write its output to a pipe instead of virtual terminal.

Also, "--no-pager" option and output through a pipe added to git tests.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
@OlegGirko

This comment has been minimized.

OlegGirko commented Sep 13, 2015

Please ignore build errors with Python 2.7 and PyPy. They are caused by hovercraft requiring Python version 3.2 or higher. However, hovercraft is used as a script, not as a module, and is run in a separate process, so it's OK if it uses other Python version. Anyway, these errors are not related to my changes. There are no errors when running tests manually with Python 2.7.

mgaitan added a commit that referenced this pull request Oct 25, 2015

Merge pull request #111 from OlegGirko/master
Run git with output to pipe instead of virtual terminal.

@mgaitan mgaitan merged commit 5ca304d into mgaitan:master Oct 25, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment