New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnicodeDecodeError in waliki.git.view. #58

Merged
merged 1 commit into from Jan 2, 2015

Conversation

Projects
None yet
3 participants
@loganchien
Contributor

loganchien commented Dec 31, 2014

Under some locale settings (e.g. zh_TW.UTF-8) the byte string
can't be properly decoded as unicode string and result in
UnicodeDecodeError.

This CL fix the problem by writing the byte string in UTF-8 and
decode them with django.utils.encoding.smart_text().

Fix UnicodeDecodeError in waliki.git.view.
Under some locale settings (e.g. zh_TW.UTF-8) the byte string
can't be properly decoded as unicode string and result in
UnicodeDecodeError.

This CL fix the problem by writing the byte string in UTF-8 and
decode them with django.utils.encoding.smart_text().
@coveralls

This comment has been minimized.

coveralls commented Dec 31, 2014

Coverage Status

Coverage increased (+0.33%) when pulling 35ca724 on loganchien:master into 1d613cd on mgaitan:master.

mgaitan added a commit that referenced this pull request Jan 2, 2015

Merge pull request #58 from loganchien/master
Fix UnicodeDecodeError in waliki.git.view.

@mgaitan mgaitan merged commit 1778b86 into mgaitan:master Jan 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mgaitan

This comment has been minimized.

Owner

mgaitan commented Jan 2, 2015

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment