New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance slides #59

Merged
merged 5 commits into from Jan 6, 2015

Conversation

Projects
None yet
3 participants
@loganchien
Contributor

loganchien commented Jan 2, 2015

This patch set contains several enhancement to the slide support:

  • Fix the MANIFEST.in for the setup tool.
  • Support hovercraft 2.0dev
  • Cleanup temporary files.
  • Close the file after reading its content.
  • Perform permission checks.

loganchien added some commits Jan 2, 2015

Fix hovercraft template distribution rules.
Without this CL, the templates for hovercraft won't be installed,
the hovercraft won't be able to find the template, and result in
KeyError.
Fix the support for hovercraft 2.0.
In the latest development branch for hovercraft, we should place
the -t option before any positional arguments.
Cleanup temorary files and close the file.
Cleanup the temporary files generated by hovercraft and
close the file explicitly after reading content of the
generated index.html.
@coveralls

This comment has been minimized.

coveralls commented Jan 2, 2015

Coverage Status

Coverage decreased (-0.25%) when pulling 1c7bbea on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien

This comment has been minimized.

Contributor

loganchien commented Jan 2, 2015

BTW, I have created the unittest for these changes as well. However, it seems that hovercover is not available on some test environment (Python 2.x). I have no idea on this at the moment. Here's the change if you are interested in:
loganchien@4f63857

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.28%) when pulling 83c4cad on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien loganchien force-pushed the loganchien:enhance-slides branch 2 times, most recently from c8548d9 to 19e68c4 Jan 3, 2015

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.45%) when pulling 19e68c4 on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien loganchien force-pushed the loganchien:enhance-slides branch from 19e68c4 to 2184149 Jan 3, 2015

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.45%) when pulling 2184149 on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien loganchien force-pushed the loganchien:enhance-slides branch 2 times, most recently from d1da7ff to a0b751b Jan 3, 2015

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.45%) when pulling a0b751b on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.45%) when pulling a0b751b on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien loganchien force-pushed the loganchien:enhance-slides branch from a0b751b to 70e5c58 Jan 3, 2015

@coveralls

This comment has been minimized.

coveralls commented Jan 3, 2015

Coverage Status

Coverage increased (+1.45%) when pulling 70e5c58 on loganchien:enhance-slides into 1778b86 on mgaitan:master.

@loganchien

This comment has been minimized.

Contributor

loganchien commented Jan 3, 2015

After several try-and-error, the unittest should work with both python 2.7 and pypy. Although due to some strange problem, we have to install configparser with easy_install in Travis CI.

mgaitan added a commit that referenced this pull request Jan 6, 2015

@mgaitan mgaitan merged commit cec80c5 into mgaitan:master Jan 6, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mgaitan

This comment has been minimized.

Owner

mgaitan commented Jan 6, 2015

Seems amazing. Thanks!

@loganchien loganchien deleted the loganchien:enhance-slides branch Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment