From 68985d88e9a44291b00d1221b983aa832adeff4c Mon Sep 17 00:00:00 2001 From: Jeffrey Pfau Date: Wed, 4 Jan 2017 16:02:22 -0800 Subject: [PATCH] Libretro: Fix saving in GB games (fixes #486) --- CHANGES | 1 + src/platform/libretro/libretro.c | 35 ++++++++++++++++++++------------ 2 files changed, 23 insertions(+), 13 deletions(-) diff --git a/CHANGES b/CHANGES index 26137042470..cb2f9ebbf47 100644 --- a/CHANGES +++ b/CHANGES @@ -13,6 +13,7 @@ Bugfixes: - GBA BIOS: Implement BitUnPack - ARM7: Fix MLA/*MULL/*MLAL timing - GBA: Fix multiboot ROM loading + - Libretro: Fix saving in GB games (fixes mgba.io/i/486) Misc: - SDL: Remove scancode key input - GBA Video: Clean up unused timers diff --git a/src/platform/libretro/libretro.c b/src/platform/libretro/libretro.c index 1f7727f5b0f..95f3f8e246a 100644 --- a/src/platform/libretro/libretro.c +++ b/src/platform/libretro/libretro.c @@ -13,12 +13,12 @@ #include #ifdef M_CORE_GB #include +#include #endif #ifdef M_CORE_GBA #include #include #include -#include #endif #include #include @@ -524,19 +524,28 @@ size_t retro_get_memory_size(unsigned id) { if (id != RETRO_MEMORY_SAVE_RAM) { return 0; } - switch (((struct GBA*) core->board)->memory.savedata.type) { - case SAVEDATA_AUTODETECT: - case SAVEDATA_FLASH1M: - return SIZE_CART_FLASH1M; - case SAVEDATA_FLASH512: - return SIZE_CART_FLASH512; - case SAVEDATA_EEPROM: - return SIZE_CART_EEPROM; - case SAVEDATA_SRAM: - return SIZE_CART_SRAM; - case SAVEDATA_FORCE_NONE: - return 0; +#ifdef M_CORE_GBA + if (core->platform(core) == PLATFORM_GBA) { + switch (((struct GBA*) core->board)->memory.savedata.type) { + case SAVEDATA_AUTODETECT: + case SAVEDATA_FLASH1M: + return SIZE_CART_FLASH1M; + case SAVEDATA_FLASH512: + return SIZE_CART_FLASH512; + case SAVEDATA_EEPROM: + return SIZE_CART_EEPROM; + case SAVEDATA_SRAM: + return SIZE_CART_SRAM; + case SAVEDATA_FORCE_NONE: + return 0; + } } +#endif +#ifdef M_CORE_GB + if (core->platform(core) == PLATFORM_GB) { + return ((struct GB*) core->board)->sramSize; + } +#endif return 0; }