diff --git a/CHANGES b/CHANGES index 591a966f876..853ed76b9a5 100644 --- a/CHANGES +++ b/CHANGES @@ -24,6 +24,7 @@ Bugfixes: - GB Audio: Fix NRx2 writes while active (fixes mgba.io/i/866) - GBA BIOS: Use core's VRAM variable instead of renderer's - GBA Savedata: Fix 512 byte EEPROM saving as 8kB (fixes mgba.io/i/877) + - SDL: Fix potential race condition when pressing keys (fixes mgba.io/i/872) Misc: - Qt: Don't rebuild library view if style hasn't changed - SDL: Fix 2.0.5 build on macOS under some circumstances diff --git a/src/platform/sdl/sdl-events.c b/src/platform/sdl/sdl-events.c index 38ada79a577..2e5e88e81ec 100644 --- a/src/platform/sdl/sdl-events.c +++ b/src/platform/sdl/sdl-events.c @@ -411,11 +411,13 @@ static void _mSDLHandleKeypress(struct mCoreThread* context, struct mSDLPlayer* key = mInputMapKey(sdlContext->bindings, SDL_BINDING_KEY, event->keysym.sym); } if (key != -1) { + mCoreThreadInterrupt(context); if (event->type == SDL_KEYDOWN) { context->core->addKeys(context->core, 1 << key); } else { context->core->clearKeys(context->core, 1 << key); } + mCoreThreadContinue(context); return; } if (event->keysym.sym == SDLK_TAB) { @@ -516,21 +518,23 @@ static void _mSDLHandleKeypress(struct mCoreThread* context, struct mSDLPlayer* } } -static void _mSDLHandleJoyButton(struct mCore* core, struct mSDLPlayer* sdlContext, const struct SDL_JoyButtonEvent* event) { +static void _mSDLHandleJoyButton(struct mCoreThread* context, struct mSDLPlayer* sdlContext, const struct SDL_JoyButtonEvent* event) { int key = 0; key = mInputMapKey(sdlContext->bindings, SDL_BINDING_BUTTON, event->button); if (key == -1) { return; } + mCoreThreadInterrupt(context); if (event->type == SDL_JOYBUTTONDOWN) { - core->addKeys(core, 1 << key); + context->core->addKeys(context->core, 1 << key); } else { - core->clearKeys(core, 1 << key); + context->core->clearKeys(context->core, 1 << key); } + mCoreThreadContinue(context); } -static void _mSDLHandleJoyHat(struct mCore* core, struct mSDLPlayer* sdlContext, const struct SDL_JoyHatEvent* event) { +static void _mSDLHandleJoyHat(struct mCoreThread* context, struct mSDLPlayer* sdlContext, const struct SDL_JoyHatEvent* event) { int allKeys = mInputMapHat(sdlContext->bindings, SDL_BINDING_BUTTON, event->hat, -1); if (allKeys == 0) { return; @@ -538,11 +542,13 @@ static void _mSDLHandleJoyHat(struct mCore* core, struct mSDLPlayer* sdlContext, int keys = mInputMapHat(sdlContext->bindings, SDL_BINDING_BUTTON, event->hat, event->value); - core->clearKeys(core, allKeys ^ keys); - core->addKeys(core, keys); + mCoreThreadInterrupt(context); + context->core->clearKeys(context->core, allKeys ^ keys); + context->core->addKeys(context->core, keys); + mCoreThreadContinue(context); } -static void _mSDLHandleJoyAxis(struct mCore* core, struct mSDLPlayer* sdlContext, const struct SDL_JoyAxisEvent* event) { +static void _mSDLHandleJoyAxis(struct mCoreThread* context, struct mSDLPlayer* sdlContext, const struct SDL_JoyAxisEvent* event) { int clearKeys = ~mInputClearAxis(sdlContext->bindings, SDL_BINDING_BUTTON, event->axis, -1); int newKeys = 0; int key = mInputMapAxis(sdlContext->bindings, SDL_BINDING_BUTTON, event->axis, event->value); @@ -550,8 +556,10 @@ static void _mSDLHandleJoyAxis(struct mCore* core, struct mSDLPlayer* sdlContext newKeys |= 1 << key; } clearKeys &= ~newKeys; - core->clearKeys(core, clearKeys); - core->addKeys(core, newKeys); + mCoreThreadInterrupt(context); + context->core->clearKeys(context->core, clearKeys); + context->core->addKeys(context->core, newKeys); + mCoreThreadContinue(context); } @@ -581,13 +589,13 @@ void mSDLHandleEvent(struct mCoreThread* context, struct mSDLPlayer* sdlContext, break; case SDL_JOYBUTTONDOWN: case SDL_JOYBUTTONUP: - _mSDLHandleJoyButton(context->core, sdlContext, &event->jbutton); + _mSDLHandleJoyButton(context, sdlContext, &event->jbutton); break; case SDL_JOYHATMOTION: - _mSDLHandleJoyHat(context->core, sdlContext, &event->jhat); + _mSDLHandleJoyHat(context, sdlContext, &event->jhat); break; case SDL_JOYAXISMOTION: - _mSDLHandleJoyAxis(context->core, sdlContext, &event->jaxis); + _mSDLHandleJoyAxis(context, sdlContext, &event->jaxis); break; } }