Permalink
Browse files

GB Memory: Fix HDMA count starting in mode 0 (fixes #855)

  • Loading branch information...
endrift committed Aug 12, 2017
1 parent 33fcd5e commit e80a2417484cb68e2177403fe9d522a22c8f4c0d
Showing with 7 additions and 2 deletions.
  1. +1 −0 CHANGES
  2. +5 −2 src/gb/memory.c
  3. +1 −0 src/gb/video.c
View
@@ -18,6 +18,7 @@ Bugfixes:
- Qt: Fix timezone issues with time overrides
- Qt: Fix sprite export pausing game indefinitely (fixes mgba.io/i/841)
- GB Video: Fix potential hang when ending mode 0
+ - GB Memory: Fix HDMA count starting in mode 0 (fixes mgba.io/i/855)
Misc:
- Qt: Don't rebuild library view if style hasn't changed
- SDL: Fix 2.0.5 build on macOS under some circumstances
View
@@ -464,10 +464,13 @@ void GBMemoryWriteHDMA5(struct GB* gb, uint8_t value) {
bool wasHdma = gb->memory.isHdma;
gb->memory.isHdma = value & 0x80;
if ((!wasHdma && !gb->memory.isHdma) || gb->video.mode == 0) {
- gb->memory.hdmaRemaining = ((value & 0x7F) + 1) * 0x10;
+ if (gb->memory.isHdma) {
+ gb->memory.hdmaRemaining = 0x10;
+ } else {
+ gb->memory.hdmaRemaining = ((value & 0x7F) + 1) * 0x10;
+ }
gb->cpuBlocked = true;
mTimingSchedule(&gb->timing, &gb->memory.hdmaEvent, 0);
- gb->cpu->nextEvent = gb->cpu->cycles;
}
}
View
@@ -231,6 +231,7 @@ void _endMode3(struct mTiming* timing, void* context, uint32_t cyclesLate) {
GBVideoProcessDots(video);
if (video->ly < GB_VIDEO_VERTICAL_PIXELS && video->p->memory.isHdma && video->p->memory.io[REG_HDMA5] != 0xFF) {
video->p->memory.hdmaRemaining = 0x10;
+ video->p->cpuBlocked = true;
mTimingDeschedule(timing, &video->p->memory.hdmaEvent);
mTimingSchedule(timing, &video->p->memory.hdmaEvent, 0);
}

0 comments on commit e80a241

Please sign in to comment.