GB Video: Fix enabling window when LY > WY (fixes #409)

mgba-emu · May 20, 2018 · ed99f8b9257e407a6b3a1191af4360d221d812e2 · ed99f8b
1 parent bc88f23
commit ed99f8b9257e407a6b3a1191af4360d221d812e2
diff --git a/CHANGES b/CHANGES
@@ -32,6 +32,7 @@ Bugfixes:
  - GBA Timer: Fix timers sometimes being late (fixes mgba.io/i/1012)
  - GBA Hardware: Fix RTC overriding light sensor (fixes mgba.io/i/1069)
  - GBA Savedata: Fix savedata modified time updating when read-only
+ - GB Video: Fix enabling window when LY > WY (fixes mgba.io/i/409)
 Misc:
  - GBA Timer: Use global cycles for timers
  - GBA: Extend oddly-sized ROMs to full address space (fixes mgba.io/i/722)
diff --git a/cinema/gb/window/wmm-hud/baseline_0000.png b/cinema/gb/window/wmm-hud/baseline_0000.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0001.png b/cinema/gb/window/wmm-hud/baseline_0001.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0002.png b/cinema/gb/window/wmm-hud/baseline_0002.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0003.png b/cinema/gb/window/wmm-hud/baseline_0003.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0004.png b/cinema/gb/window/wmm-hud/baseline_0004.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0005.png b/cinema/gb/window/wmm-hud/baseline_0005.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0006.png b/cinema/gb/window/wmm-hud/baseline_0006.png
diff --git a/cinema/gb/window/wmm-hud/baseline_0007.png b/cinema/gb/window/wmm-hud/baseline_0007.png
diff --git a/cinema/gb/window/wmm-hud/test.mvl b/cinema/gb/window/wmm-hud/test.mvl
diff --git a/src/gb/renderers/software.c b/src/gb/renderers/software.c
@@ -229,7 +229,11 @@ static void GBVideoSoftwareRendererUpdateWindow(struct GBVideoSoftwareRenderer*
 			renderer->hasWindow = true;
 		} else {
 			if (!renderer->hasWindow) {
-				renderer->currentWy = renderer->lastY - renderer->wy;
+				if (renderer->lastY > renderer->wy) {
+					renderer->currentWy = GB_VIDEO_VERTICAL_PIXELS;
+				} else {
+					renderer->currentWy = renderer->lastY - renderer->wy;
+				}
 			} else {
 				renderer->currentWy += renderer->lastY;
 			}