Permalink
Browse files

GBA BIOS: Fix ArcTan2 sign in HLE BIOS (fixes #689)

  • Loading branch information...
endrift committed Apr 21, 2017
1 parent c9d411a commit f4abdd6c4c475c5249754d184abc9c42d63c24b0
Showing with 4 additions and 3 deletions.
  1. +1 −0 CHANGES
  2. +3 −3 src/gba/bios.c
View
@@ -39,6 +39,7 @@ Bugfixes:
- FFmpeg: Fix overflow and general issues with audio encoding
- Qt: Fix crash when changing audio settings after a game is closed
- GBA BIOS: Fix ArcTan sign in HLE BIOS
- GBA BIOS: Fix ArcTan2 sign in HLE BIOS
Misc:
- SDL: Remove scancode key input
- GBA Video: Clean up unused timers
View
@@ -283,7 +283,7 @@ static int16_t _ArcTan(int32_t i) {
return (i * b) >> 16;
}
static int16_t _ArcTan2(int16_t x, int16_t y) {
static int16_t _ArcTan2(int32_t x, int32_t y) {
if (!y) {
if (x >= 0) {
return 0;
@@ -299,7 +299,7 @@ static int16_t _ArcTan2(int16_t x, int16_t y) {
if (y >= 0) {
if (x >= 0) {
if (x >= y) {
return _ArcTan((y << 14)/ x);
return _ArcTan((y << 14) / x);
}
} else if (-x >= y) {
return _ArcTan((y << 14) / x) + 0x8000;
@@ -359,7 +359,7 @@ void GBASwi16(struct ARMCore* cpu, int immediate) {
cpu->gprs[0] = _ArcTan(cpu->gprs[0]);
break;
case 0xA:
cpu->gprs[0] = (uint16_t) _ArcTan2(cpu->gprs[0], cpu->gprs[1]);
cpu->gprs[0] = _ArcTan2(cpu->gprs[0], cpu->gprs[1]);
break;
case 0xB:
case 0xC:

0 comments on commit f4abdd6

Please sign in to comment.