New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Game Boy enhancement not working for Pokemon Yellow. #1104

Open
bslenul opened this Issue Jun 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@bslenul

bslenul commented Jun 19, 2018

Hey!

  • Pokemon Yellow seems to be the only Game Boy game with both Game Boy Color AND Super Game Boy enhancements.
  • GBC enhancement works fine as you can see on the screen below, SGB enhancement however doesnt work and that's the issue.
  • With Game Boy Color model set to Autodetect in the settings no problem, the game runs like a GBC game:

pokemon - yellow version - special pikachu edition usa europe gbc sgb enhanced -180619-000655

(same behavior with the option set to Game Boy Color or Game Boy Advance)

  • With the option set to Game Boy again no problem the game runs like a GB game:

pokemon - yellow version - special pikachu edition usa europe gbc sgb enhanced -180619-000729

  • But with the option set to Super Game Boy, instead of having colors and SGB borders like this, the game is in black and white and borders are white:

pokemon - yellow version - special pikachu edition usa europe gbc sgb enhanced -180619-000802

  • SGB enhancement works perfectly fine on other games like Pokemon Red/Blue. I guess this is because of the GBC enhancement of Yellow?

pokemon - red version usa europe sgb enhanced -180619-005305

Screens taken from RetroArch but results are the same with mGBA-build-2018-06-03-win32-5135-f8759a8760f4af6bd12188beeae82fb4e2ea5585 on Windows 10.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 19, 2018

Member

Hmm, seems to work fine with the SDL port. Looking into the Qt one now.

E] Can reproduce, Qt port is broken.

Member

endrift commented Jun 19, 2018

Hmm, seems to work fine with the SDL port. Looking into the Qt one now.

E] Can reproduce, Qt port is broken.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 19, 2018

Member

Seems like Pokémon Yellow asks for 2-controller mode, then increments which controller it's asking for 8 times (which goes back to the first controller) and since it sees it's the first controller again assumes it's not a SGB...

Member

endrift commented Jun 19, 2018

Seems like Pokémon Yellow asks for 2-controller mode, then increments which controller it's asking for 8 times (which goes back to the first controller) and since it sees it's the first controller again assumes it's not a SGB...

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 19, 2018

Member

I think this might be a timing issue. I think it swaps the controller every frame, but it takes too many frames and winds up being an even number of frames (8) instead of an odd number (5 in BGB unless I miscounted).

Member

endrift commented Jun 19, 2018

I think this might be a timing issue. I think it swaps the controller every frame, but it takes too many frames and winds up being an even number of frames (8) instead of an odd number (5 in BGB unless I miscounted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment