/mgba

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio channels not always cut off on rewind #1107

Closed
NarryG opened this Issue Jun 23, 2018 · 4 comments

Comments

Assignees
No one assigned
Labels
feature:audio
Projects
None yet
Milestone
No milestone
2 participants
@NarryG @endrift
@NarryG
Copy link

NarryG commented Jun 23, 2018

In certain games (Mario & Luigi Superstar Saga being the example I have), it appears that rewind isn't properly cutting off certain audio channels.

This issue exists in both the 0.6.x branch (including 0.6.3 stable) as well as the 0.7.x branch

Here's a clip demonstrating the issue:
https://streamable.com/muc4b

@endrift endrift added the feature:audio label Jun 23, 2018

@endrift

This comment has been minimized.

Sign in to view
Copy link
Member

endrift commented Jun 23, 2018

Can reproduce. Channel 3 is the faulty one here.

@endrift endrift closed this in b67b192 Jun 23, 2018

@NarryG

This comment has been minimized.

Sign in to view
Copy link
Author

NarryG commented Jun 24, 2018

Could this be backported to 0.6.X so it can be merged into Bizhawk?
@endrift

This comment has been minimized.

Sign in to view
Copy link
Member

endrift commented Jun 24, 2018

Yup, though hopefully 0.7 comes out soon so they can adopt it.

@NarryG NarryG referenced this issue Jun 24, 2018

Closed

mGBA Audio Keeps Playing Notes after Rewind #1195

endrift added a commit that referenced this issue Jun 24, 2018

@endrift
GBA Serialize: Fix loading channel 3 volume (fixes #1107)
47f3358
@endrift

This comment has been minimized.

Sign in to view
Copy link
Member

endrift commented Jun 24, 2018

Done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment