New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio channels not always cut off on rewind #1107

Closed
NarryG opened this Issue Jun 23, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@NarryG

NarryG commented Jun 23, 2018

In certain games (Mario & Luigi Superstar Saga being the example I have), it appears that rewind isn't properly cutting off certain audio channels.

This issue exists in both the 0.6.x branch (including 0.6.3 stable) as well as the 0.7.x branch

Here's a clip demonstrating the issue:
https://streamable.com/muc4b

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 23, 2018

Member

Can reproduce. Channel 3 is the faulty one here.

Member

endrift commented Jun 23, 2018

Can reproduce. Channel 3 is the faulty one here.

@endrift endrift closed this in b67b192 Jun 23, 2018

@NarryG

This comment has been minimized.

Show comment
Hide comment
@NarryG

NarryG Jun 24, 2018

Could this be backported to 0.6.X so it can be merged into Bizhawk?

NarryG commented Jun 24, 2018

Could this be backported to 0.6.X so it can be merged into Bizhawk?

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 24, 2018

Member

Yup, though hopefully 0.7 comes out soon so they can adopt it.

Member

endrift commented Jun 24, 2018

Yup, though hopefully 0.7 comes out soon so they can adopt it.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jun 24, 2018

Member

Done.

Member

endrift commented Jun 24, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment