Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
(RetroArch) Real Time Clock appears broken in 0.7-WIP #1134
(Crosspost as I wasn't sure wether to post this here or at https://github.com/libretro/mgba/.)
The Real Time Clock displays an incorrect time in Pokemon Liquid Crystal (romhack).
The RTC functions correctly in VBA Next, provided the cart ID is changed to that of Pokemon Ruby using a hex editor (as the hack is based on FireRed, which did not use RTC).
The time displayed should be that of the system clock - instead it is always Thursday, 22:105, and 0:00 if the game ID is not changed to that of Pokemon Ruby.
To reproduce the bug:
Did some digging myself after running into this exact problem.
After some bisecting between
I have literally no idea what the implications are of reverting that patch, but hopefully that's helpful information.
added a commit
Nov 3, 2018
@fennectech, that BPRE → AXVE trick in hex editor didn't work for the 0.7 beta 1 release when checked in the Windows and 3DS builds (and subsequent nighties before and after til this point). I came here after finding out that Liquid Crystal can be played with RTC as a GBA VC injection from this thread here.
This lead back to the question whether this game's RTC functions because of hacky rom patch work, or that it's supposed work on real hardware if we go by 3DS ≃ DSi ≃ NDS ≃ GBA.
@endrift, thanks for fixing this. Gonna giddity share the news back at GBAtemp.