Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Save type overrides in config.ini are ignored (Mac OS Mojave, mGBA v0.7.1) #1354

Closed
PikalaxALT opened this issue Mar 14, 2019 · 3 comments

Comments

@PikalaxALT
Copy link

commented Mar 14, 2019

Steps taken:

  • Launch mGBA
  • Tools > Game Overrides...
  • Set save type to "Flash 1Mb" and hardware to "RTC", deselecting "Autodetect"
  • Load a modified copy of Pokemon Sapphire with a custom game code (PMSE)
  • Once the game starts to run, click "Save" in the Game Overrides window
  • Close mGBA
  • Launch mGBA anew
  • Load the same ROM without setting up the overrides (using cmd+0)

Expected outcome: Modified Sapphire runs normally, with no in-game error messages regarding the 1M subcircuit board or the internal battery.

Observed:

  • Game fails to load. Log indicates that it autodetected the save type as Flash 512kb, which is incorrect.
  • If I recompile the ROM with the boot-time flash check commented out, it will run but present the "1M subcircuit board is not installed" and "Internal battery has run dry" errors when progressing beyond the title screen.
  • The override.PMSE entry does exist in the file ~/.config/mgba/config.ini as expected, however it seems to be entirely unused by the emulator.

A similar issue was incorrectly filed as #1353.

@endrift

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Can you upload the patch? I can't seem to reproduce using Pokémon Normal Version as the ROM hack (which has a code of PNV7). Also, make sure the override says savetype=FLASH1M and hardware=1. I know the override dialog can be a bit finicky and I'd like to fix that in 0.8.

@PikalaxALT

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

While I cannot give you a patch with all the changes I made, I can supply an xDelta patch on Pokemon Sapphire US-EN v1.0 (SHA1: 3ccbbd45f8553c36463f13b938e833f652b793e4) that makes a minimal set of changes to reproduce the issue in mGBA:
romcode.xdelta.gz

@endrift

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Confirmed. I'll have a fix out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.