Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour related to mute toggle when fast forwarding + miscellaneous improvements #1424

Closed
iuzwpr2p39rh7w opened this issue May 27, 2019 · 2 comments

Comments

@iuzwpr2p39rh7w
Copy link

@iuzwpr2p39rh7w iuzwpr2p39rh7w commented May 27, 2019

Muting the audio by clicking on "Audio/Video" -> "Mute" then unlocking the FPS target with "Fast forward (held)" or "Fast forward" (Tab and Shift+Tab, respectively) will unmute the audio.
I had just muted the game audio because I was only testing something which did not require game audio for a while so I opted to listen to something else and turned the system audio back up leading to me being mildly startled by the loud high-pitched game intro.
After some research, I learned that this issue had been brought up before and that there is a seperate setting for muting fast forward volume. Toggling it requires three mouse clicks ("Tools" -> "Settings..." -> [Audio/Video ->] "Mute") and does not seem to be assignable to a shortcut. Having the option to mute the audio output when fast forwarding independently of the normal audio is useful, but I do not find it intuitive as I would expect the game audio to be quiet after clicking on "Mute", as did Cibomatto2002 in the aforementioned issue.
My proposed solution is to mute all audio when "Mute" is enabled, as I do not know of a scenario where one would want to disable the normal but not the sped up audio, add an entry for muting audio only when fast forwarding under "Mute" and make it also assignable to a shortcut.

Unrelated to this issue, I suggest assigning "Ctrl+M" as default key combination to toggle muting the audio as it currently is unbound and should be intuitive to other users. Personally, I would like to be able to see the audio levels also as percentages instead of just as unlabeled sliders. Even better would be to add the ability to manually input specific values.
Additionally, I want to point out that the No-Intro .dat should be updated. It may not be necessary to do this for each release, but the three .dat files, that nointro.dat is based on, are more than three years out of date.
Finally, the copyright information scattered over many different souce files and visible on the Windows binary under "Properties" -> "Details" is out of date and does not match your website's footer.

@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented May 28, 2019

I've updated the dat.

I'll look into the mute thing tomorrow. That sounds like a bit of an oversight that the menu setting doesn't affect both.

You're right that the copyrights are generally out of date. However, that's not hugely important. I don't generally set all of them to the current year on projects anymore, only when I make big changes to files, and I've been forgetting.

@endrift endrift closed this in e838320 May 29, 2019
@endrift

This comment has been minimized.

Copy link
Member

@endrift endrift commented May 29, 2019

I thought about default assigning Ctrl+M, but it would have required a bit of restructuring that didn't seem worthwhile, especially since manually binding it is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.