Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBVisualizer (GBC) doesnt show the oscillation wave #1468

Open
benderscruffy opened this issue Jun 25, 2019 · 3 comments
Open

GBVisualizer (GBC) doesnt show the oscillation wave #1468

benderscruffy opened this issue Jun 25, 2019 · 3 comments
Labels
platform:GB/GBC severity:enhancement
Milestone
mGBA 1.0.0

Comments

@benderscruffy
Copy link

@benderscruffy benderscruffy commented Jun 25, 2019

https://github.com/LIJI32/GBVisualizer
@endrift endrift added the severity:enhancement label Jun 26, 2019
@endrift endrift added the platform:GB/GBC label Jul 3, 2019
@endrift endrift added this to the mGBA 1.0.0 milestone Aug 26, 2019
@ghost
Copy link

@ghost ghost commented Nov 15, 2019

Hello,
I would like to work on this issue, and I was just wondering if anyone could provide details to get this to work. I assume it would just be adding functionality for the registers that GBVisualizer needs, but I am not sure. Thank you!

@endrift
Copy link
Member

@endrift endrift commented Nov 15, 2019

Yes, you would need to add support for the registers to read the current samples. This may be more complex than it sounds. I'm not sure offhand.

@ghost ghost mentioned this issue Dec 11, 2019
Closed
@endrift endrift mentioned this issue Nov 25, 2020
Closed
@pinobatch
Copy link

@pinobatch pinobatch commented Nov 25, 2020

Keywords for future searches: GBC PCM, PCM12 (FF76), PCM34 (FF77)

endrift added a commit that referenced this issue Nov 26, 2020
@endrift
GB I/O: Implement preliminary support for PCM12/PCM34 (#1468)
b50d8e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GB/GBC severity:enhancement
Projects
None yet
Milestone
mGBA 1.0.0
Development

Successfully merging a pull request may close this issue.

GBVisualizer support
3 participants
@endrift @benderscruffy @pinobatch