Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video filters #15

Closed
ROMaster2 opened this issue Apr 24, 2015 · 18 comments
Closed

Video filters #15

ROMaster2 opened this issue Apr 24, 2015 · 18 comments
Assignees
Milestone

Comments

@ROMaster2
Copy link

@ROMaster2 ROMaster2 commented Apr 24, 2015

[Enhancement]

Video filters like hq2x, hq3x, and 2xSaI would be nice when the resolution is larger, so it wouldn't look quite as pixelated.

Great job on everything else so far!

@purpasmart96
Copy link

@purpasmart96 purpasmart96 commented Apr 24, 2015

Those filters are kinda garbage as of 2015, xbrz or just plain xbr is in my opinion superior to those. but a plain bilinear filter or just some support for retroarch shaders would be nice.

@CarterLi
Copy link

@CarterLi CarterLi commented Apr 25, 2015

+1 for xbrz

@endrift
Copy link
Member

@endrift endrift commented Apr 25, 2015

In bugzilla already: http://mgba.io/b/192

@endrift endrift added this to the 0.3.0 milestone Apr 25, 2015
@endrift endrift self-assigned this Apr 25, 2015
@ROMaster2
Copy link
Author

@ROMaster2 ROMaster2 commented May 19, 2015

While I'm certain it won't be a problem, I'll point it out since puNES doesn't support it (yet).

When enabling the video filters (like 2xBRZ, 3xBRZ), allow game/window scale be independent of it, at least in integer multiples. I like using x6 scale with a x2 or x3 video filter.

@endrift endrift added this to the 0.4.0 milestone Jul 2, 2015
@endrift endrift removed this from the 0.3.0 milestone Jul 2, 2015
@elcorsico
Copy link

@elcorsico elcorsico commented Aug 23, 2015

how enable video filter ? just resample video for me.
add xBRZ and other please..

@RinMaru
Copy link

@RinMaru RinMaru commented Oct 11, 2015

xBRZ tends to be very slow on low end Computers AdvanceMame2X filter or HQ3X is as high as I can go On my old Rig with VBA-M, ever since 2.0.1 Beta it's been a very demanding emulator

@ROMaster2
Copy link
Author

@ROMaster2 ROMaster2 commented Oct 11, 2015

Well it would be optional. That, and once video filters are added in it'll be easier to add more.

@jordant2
Copy link

@jordant2 jordant2 commented Oct 16, 2015

From what I understand, right now mGBA runs (30%?) faster than VBA-M to begin with, so even more intensive filters wouldn't be as noticeable. Not to mention it doesn't make sense to not implement better filters just because they won't work on low end hardware. That's what having multiple options is for :)

@endrift
Copy link
Member

@endrift endrift commented Jan 23, 2016

xBR added, but I won't be adding xBRZ as it can't be done on the GPU.

@endrift
Copy link
Member

@endrift endrift commented Jan 24, 2016

Closing, since all of the major featurework is done.

@endrift endrift closed this Jan 24, 2016
@inukaze
Copy link

@inukaze inukaze commented Feb 27, 2016

Hi there, someone can tell me if this emulator have Video Filters / Shaders , like : lq /hq ( 2x 4x ) SuperEagle , 2xSai , Super2XSai , Bilinear , Bilinear Plus , AdvanceMAME 2X , xBRZ 2x ?

Because i can't see any option in the QT Menu for active it
Here i read "https://forums.mgba.io/printthread.php?tid=12" : Anti-aliasing is just done using OpenGL's bilinear filtering. It's usable in both the Qt and SDL versions (but you need to edit a config file to get it in the SDL version.

Which line i must use to active it ?

@ajusa
Copy link

@ajusa ajusa commented Apr 3, 2016

I also do not know how to activate these filters. They are not in any config file, from what I can see.

@seanbperiod
Copy link

@seanbperiod seanbperiod commented Aug 2, 2017

Any update on this and how to activate?

@nacimgoura
Copy link

@nacimgoura nacimgoura commented Aug 8, 2017

Is it still not possible to apply filters?

@endrift
Copy link
Member

@endrift endrift commented Aug 8, 2017

I don't understand. It's been possible for over a year. It's under Shader Settings, which is in the A/V menu (formerly) or under settings (presently).

@seanbperiod
Copy link

@seanbperiod seanbperiod commented Aug 8, 2017

I don't see it for Vita. Only see a Configure Menu from the pause menu, and Screen Mode, Frameskip. Nothing related to filters.

@endrift
Copy link
Member

@endrift endrift commented Aug 8, 2017

It's not on Vita, since the Vita does not use OpenGL. See #448 for discussions on that. This issue only applies to desktop platforms.

@RunisDauphin
Copy link

@RunisDauphin RunisDauphin commented Apr 8, 2019

I have tried xBR filters on a 3,40 GHz i7-2600 computer and it is not capable of moving such thing above 50%.

Could you add at least filters for those who have crappy computers?

And by the way, hq filters in other emulators (such as Kega Fusion, Mesen, SNES 9X, VBA and DeSmuME) work fine and look like if the game was made in the 7th generation.

Please, consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet