Skip to content

Shutdown option keeps handle on rom files #1659

Closed

Description

@AsparagusEduardo

I don't know if this intentional behaviour, but by using the shutdown option it doesn't let me recopile the rom file.

image

EDIT: Tried it in 0.7.2 and 0.7.3 and the issue doesn't happen, so it must've been introduced in 0.8.0

Activity

  1. added
    port:QtAffects the Qt version (the standard desktop version)
    severity:regressionIssues that were not present in previous versions
    on Feb 2, 2020
  2. endrift commented on Feb 2, 2020

    @endrift
    Member

    On my end it looks like it's just the window title not getting updated; the file handle appears to be closed. Did you have any other windows open when you hit Shutdown?

  3. AsparagusEduardo commented on Feb 3, 2020

    @AsparagusEduardo
    Author

    No, I didn't have any other mGBA windows open
    I was referred to make an issue report from the pokeemerald project Discord when I tried compiling after pressing Shutdown, and they told me that the common issue with that error is the file handle being open.
    image

  4. endrift commented on Feb 3, 2020

    @endrift
    Member

    So I can reproduce this, but the file handle has definitely been closed. Process Explorer can't see it. I wonder if I'm not unmapping the memory properly before closing it.

    E] That appears to be exactly what's happening.

  5. added and removed
    severity:regressionIssues that were not present in previous versions
    on Feb 4, 2020
  6. endrift commented on Feb 4, 2020

    @endrift
    Member

    Should have a fix for this tonight.

  7. added a commit that references this issue on Feb 8, 2020
    5d58944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    port:QtAffects the Qt version (the standard desktop version)system:WindowsAffects running on Windows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions