Skip to content

/ mgba

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELF loading regression from 0.8.0 to 0.8.1 #1669

Closed
Sierraffinity opened this issue Feb 17, 2020 · 2 comments
Closed

ELF loading regression from 0.8.0 to 0.8.1 #1669

Sierraffinity opened this issue Feb 17, 2020 · 2 comments

Comments

@Sierraffinity
Copy link

@Sierraffinity Sierraffinity commented Feb 17, 2020

On 0.8.0 I used to be able to load the pokeemerald ELF file, and run it normally. In 0.8.1, however, it crashes on a white screen on boot presumably because it can't find the header (the name in the status bar is blank) so the save type is wrong.
@endrift
Copy link
Member

@endrift endrift commented Feb 17, 2020

Are you sure? #1450 was never closed...
@Sierraffinity
Copy link
Author

@Sierraffinity Sierraffinity commented Feb 17, 2020

Yeah, here's the ELF loaded in 0.8.0 and 0.8.1, side by side:
image
@endrift endrift closed this in 7d382e8 Feb 17, 2020
endrift added a commit that referenced this issue Feb 17, 2020
@endrift
Core: Fix ELF loading regression (fixes #1669)
5f3dc72
@endrift endrift mentioned this issue Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@endrift @Sierraffinity