Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background horizontal mosaic isn't shown as expected when horizontal position is changed midframe #1684

Closed
GValiente opened this issue Mar 4, 2020 · 4 comments
Closed

Background horizontal mosaic isn't shown as expected when horizontal position is changed midframe #1684

GValiente opened this issue Mar 4, 2020 · 4 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Milestone
mGBA 0.9.0

Comments

@GValiente
Copy link

GValiente commented Mar 4, 2020 •
edited

Test rom:
mosaic-test.zip

mGBA tested versions:
0.8.1 and 6156-8d194fa.

If the horizontal position of the background is not changed midframe, horizontal mosaic is shown as expected.
Of all tested emulators, VBA is the only one which seems to get it right:

mGBA - (60 fps) - 0 8 1 3_4_2020 9_30_26 AM

No$gba Emulator 3_4_2020 9_29_57 AM

VisualBoyAdvance- 91% 3_4_2020 9_30_40 AM
@GValiente GValiente changed the title Background mosaic doesn't show as expected when horizontal position is changed midframe Background mosaic isn't shown as expected when horizontal position is changed midframe Mar 4, 2020
@GValiente
Copy link
Author

GValiente commented Mar 4, 2020 •
edited

Byuu seems to get it right too:
mosaic-test 3_4_2020 9_45_51 AM

EDIT: Nope, the first column is wrong.

@GValiente GValiente changed the title Background mosaic isn't shown as expected when horizontal position is changed midframe Background horizontal mosaic isn't shown as expected when horizontal position is changed midframe Mar 4, 2020
@endrift
Copy link
Member

endrift commented Aug 14, 2020

Do you have a non-animated version of this? It's kinda hard to compare against hardware when it's animating.

@endrift endrift added hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues labels Aug 14, 2020
@GValiente
Copy link
Author

GValiente commented Aug 14, 2020 •
edited

mgba_1684.zip

VBA seems to show the correct output:

vba

mGBA output:

mgba

@GValiente
Copy link
Author

If it helps, here's the source code of the latest test rom:
https://github.com/GValiente/butano/tree/master/issues/mgba_1684

@endrift endrift added this to the mGBA 0.9.1 milestone Mar 21, 2021
@endrift endrift modified the milestones: mGBA 0.9.1, mGBA 0.9.0 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
2 participants
@endrift @GValiente