Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameshark Saves don't import #1851

Closed
ccfman2004 opened this issue Aug 12, 2020 · 13 comments
Closed

Gameshark Saves don't import #1851

ccfman2004 opened this issue Aug 12, 2020 · 13 comments

Comments

@ccfman2004
Copy link

@ccfman2004 ccfman2004 commented Aug 12, 2020

I can't seem to get Gameshark game saves to work. I load the ROM then import the Gameshark save then reset the game but it doesn't load the Gameshark save. Not sure what to do.

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

What game? Please provide the Gameshark save.

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

This save is for a US version of Pokémon Sapphire. Did you try it with a European version?

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

My ROM is the USA/Europe version.

I know the save works with my rom as I tried it with Visual Boy Advance and it works fine.

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

There is no "USA/Europe" version of Pokémon Sapphire. The ROM site you downloaded it from mislabeled it.

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

That's what mGBA says it is.

It's Rev 2 that has the berry fix.

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

Gonna have to yell at some No-Intro datters then. Anyway, it loads fine for me.
axpe-0

E] It does NOT load fine for Rev 2.

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

The MD5 of my rom is 9bc2b765ca6997175fac51e6cdc29089

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

GameShark saves do checksum matching. Since the checksum is different, it thinks it's the wrong game and rejects. It's arguably a bug in VBA that it doesn't reject it. This information is not presented to the user though, and there's no option to override it.

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

As far as I'm aware the only difference in the rev 2 is the berry glitch is fixed.

@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

The file is different. That's enough for the checksum matching to fail. That's the whole point of checksum matching.

@ccfman2004
Copy link
Author

@ccfman2004 ccfman2004 commented Aug 12, 2020

There should be an option to override it since it's the right game just a different revision.

@endrift endrift closed this in 5c1249f Aug 12, 2020
@endrift
Copy link
Member

@endrift endrift commented Aug 12, 2020

I don't disagree. And it turns out I already had a flag for disabling checksum matching, but it wasn't zealous enough with the checks it skipped.

endrift added a commit that referenced this issue Aug 17, 2020
RetroEdit added a commit to TASVideos/mgba that referenced this issue Aug 29, 2020
…ixes mgba-emu#1851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.