Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling super game boy border makes window show garbage pixels. #1898

Closed
Lokathor opened this issue Sep 27, 2020 · 2 comments
Closed

Disabling super game boy border makes window show garbage pixels. #1898

Lokathor opened this issue Sep 27, 2020 · 2 comments
Milestone

Comments

@Lokathor
Copy link

@Lokathor Lokathor commented Sep 27, 2020

  • Version: 0.9-6424-4a28264d
  • Git Hash: master 4a28264

With a game boy game running and the Super Game Boy border displayed, if you turn off the super game boy border in the settings then the window displays garbage pixels.

  • It happens reliably, and with more than just one game (tried Pokemon Red and also Donkey Kong)
  • It doesn't happen with games that don't have a super game boy border (tried Dragon Warrior 1+2)
  • If you take a screenshot using mGBA itself the screenshot produced shows the proper output.
@Lokathor
Copy link
Author

@Lokathor Lokathor commented Sep 27, 2020

Meanwhile, this is what you actually see ("showing" the pokemon red title screen):
PXL_20200927_002211550

@endrift endrift added this to the mGBA 0.9.0 milestone Oct 1, 2020
@endrift
Copy link
Member

@endrift endrift commented Oct 7, 2020

This appears to be because the GL backend gets confused about the stride when the resolution changes. GL thinks the stride is equal to the width, whereas the core has no such illusions. It's most likely a regression, since I don't remember that issue always existing, especially when I added disabling in the first place.

@endrift endrift closed this in 7a9e1e4 Oct 12, 2020
endrift added a commit that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.