Skip to content

/ mgba

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBA/OpenGL: Sprites behind a Mode 4 background are hidden entirely #1907

Closed
lunasorcery opened this issue Oct 11, 2020 · 2 comments
Closed

GBA/OpenGL: Sprites behind a Mode 4 background are hidden entirely #1907

lunasorcery opened this issue Oct 11, 2020 · 2 comments

Comments

@lunasorcery
Copy link

@lunasorcery lunasorcery commented Oct 11, 2020

Any sprites with their priority set to draw behind a Mode 4 background will be hidden entirely - when populating the relevant background layer, the OpenGL renderer treats palette index 0 as a solid color rather than a transparent passthrough.
This might affect other background modes too; I'm not sure.

Observed on 7b3900f
Only occurs on the OpenGL Video Renderer. The Software Video Renderer is unaffected.
@endrift
Copy link
Member

@endrift endrift commented Oct 11, 2020

Do you have an example game this is used in? It's an easy fix but I want to make sure I do it properly.
@lunasorcery
Copy link
Author

@lunasorcery lunasorcery commented Oct 11, 2020 •
edited

Observed on Asterix & Obelix XXL:
Screen Shot 2020-10-11 at 22 36 47

Software renderer for comparison:
Screen Shot 2020-10-11 at 22 36 36

and Drome Racers:
Screen Shot 2020-10-11 at 22 32 04

Software renderer for comparison:
Screen Shot 2020-10-11 at 22 32 23
endrift added a commit that referenced this issue Oct 11, 2020
@endrift
GBA Video: Fix mode 4 transparency in OpenGL (fixes #1907)
Loading status checks…
d830e50
@endrift endrift closed this in 8b8ff65 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@endrift @lunasorcery