Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handling the timer cascade bit properly #2043

Closed
mattrberry opened this issue Feb 9, 2021 · 1 comment
Closed

Not handling the timer cascade bit properly #2043

mattrberry opened this issue Feb 9, 2021 · 1 comment

Comments

@mattrberry
Copy link

@mattrberry mattrberry commented Feb 9, 2021

When a timer is enabled, if its cascade bit is set then it should stop counting immediately. Unsetting it should resume the timer immediately from where it left off without reloading the counter. This is best demonstrated in the tonc tmr_demo, which is documented with source code here. Not sure of any actual impact in games.

Tonc downloads in case you somehow don't have them: https://www.coranac.com/projects/#tonc

@endrift
Copy link
Member

@endrift endrift commented Feb 9, 2021

I have a tentative fix for this, but I did some refactoring/(questionable) cleanup at the same time so I need to test it more before I push it.

@endrift endrift closed this in e12ca74 Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants