-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recording always forces yuv420p for h264 codecs even if encoder doesn't support it #2084
Comments
|
Thinking about this more, I should probably disallow putting lossless in mp4/m4v/mov, since yuv420p is not lossless. |
Yeah, it's a bit of rough spot with player compatibility. Having MKVs be the container used for lossless is a little arbitrary too, since programs like windows media player can still play MKVs if they use yuv420p just like it can MP4s. But, I get the motivation of not wanting users to get confused when they can open some MP4s but not others. |
That is indeed the motivation. It's a usability issue, as pointed out in #1693 |
I have an idea that might be interesting, but would take a fair bit of reworking. Keep the simple of view of record A/V the same or similar, maybe add a couple more knobs that are guaranteed not to bork anything. Then, change the advanced view to be more like OBS's custom FFMPEG output view, where it provides a few main knobs that apply to all encoders, then it provides separate fields for custom parameters that can be passed to the encoders. That way you can give stuff in the simple menu that will behave as expected by layman. Then kind of leave the advanced menu for power-users that know a little about FFMPEG/LIBAV. Right now the advanced window kind of sits in the uncomfortable spot where it's not flexible enough for power-users. And on the other end gives layman too many opportunities to shoot themselves in the foot and think it's mGBA's fault. |
kinda the point was to keep even the advanced menu simple enough where I didn't put a wholesale video recording thing in and people who were super power users would just transcode outside of the program. You do have a point though. |
That's fair. My hopes are probably a little out to lunch. I use mGBA to run streamed casual speedruns tournaments between friends. I basically give them a string like |
I think figuring out a better approach for this for 0.10 is a good idea to be honest. But as I have just one point of view having some people to brainstorm with is probably useful. |
Hi, I built
mgba-qt
from source on Ubuntu Focal. I tried to record with the 'lossless' preset and got an error.found this bug
strcasecmp
returns zero when strings are equal, this code to assumes the opposite.The text was updated successfully, but these errors were encountered: