Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-English FireRed detected as ROM hack #2100

Closed
cruiseliu opened this issue Mar 31, 2021 · 1 comment
Closed

Non-English FireRed detected as ROM hack #2100

cruiseliu opened this issue Mar 31, 2021 · 1 comment
Labels
platform:GBA Game Boy Advance-related issues

Comments

@cruiseliu
Copy link

cruiseliu commented Mar 31, 2021 •
edited

The commit "GBA: Fix FireRed revision misdetecting as a ROM hack" only checks CRC of English versions.
mGBA sometimes creates invalid save file for Japanese FireRed. I can't always reproduce it, but I comment out relative lines in overrides.c and it never happens again.
@endrift
Copy link
Member

endrift commented Mar 31, 2021

Yes, I was made aware of this last night and I'm working on a fix.

@endrift endrift added the platform:GBA Game Boy Advance-related issues label Mar 31, 2021
endrift added a commit that referenced this issue Apr 13, 2021
@endrift
GBA: Fix non-USA 1.0 FireRed misdetecting as a ROM hack (fixes #2100)
fefe47d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA Game Boy Advance-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endrift @cruiseliu