Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button for shortcuts has to be pressed twice when using gamepad #2143

Closed
Intiroso opened this issue Apr 25, 2021 · 8 comments
Closed

Button for shortcuts has to be pressed twice when using gamepad #2143

Intiroso opened this issue Apr 25, 2021 · 8 comments
Labels
Milestone

Comments

@Intiroso
Copy link

@Intiroso Intiroso commented Apr 25, 2021

Hello, i download previous versions until 0.7.2 for testing, and since 0.8.1 any button (even axis) assigned to shortcuts has to be pressed two times to work, every time you want to use that action.
Maybe because the solution used for #1650?

Also wanna congrats for the great GBA emulator that mGBA is (and becoming even more too).

@Intiroso Intiroso changed the title Boton for shortcuts has to be pressed twice when using gamepad Button for shortcuts has to be pressed twice when using gamepad Apr 25, 2021
@endrift
Copy link
Member

@endrift endrift commented Apr 25, 2021

What gamepad are you using? I use gamepads and have never seen this issue. What are some examples of the actions you're using? Does this apply to all actions?

@Intiroso
Copy link
Author

@Intiroso Intiroso commented Apr 25, 2021

I forgot to put those details.
Already tried with three diferents gamepads: wireless Xbox 360, Logitech Cordless Rumblepad 2 and a Gamecube controller using a Mayflash adapter. I use 4 shortcuts, Load and Save State, Fast forward held (this works as intended) and Toggle fullscreen.

My OS is Windows 7 64bits (tried both versións of the emu, 32b and 64b)

Another thing, every time you open the emulator its trigger any of the shortcuts with just one press, after that "first" action, it will work only with 2 presses (for each shortcut that has used the "first" press). This happens every time you close and reopen the program.
Also doesn't matter the moment of the second push to trigger the shortcut, could be immediately or several seconds latetly, even if you use other buttons between those principal actions, the shortcut always activates the moment that you press the desingned button for a 2nd time.

@endrift
Copy link
Member

@endrift endrift commented Apr 25, 2021

Alright, I'll see if I can reproduce. If so I'll schedule this for 0.9.2.

@Intiroso
Copy link
Author

@Intiroso Intiroso commented Apr 25, 2021

Thank you very much

@Hexaae
Copy link
Contributor

@Hexaae Hexaae commented Apr 27, 2021

Can't reproduce here with Win 10 and mGBA 0.9.1. I assigned ffwd to right-stick of XBox One Bluetooth and always works fine on first press (and next presses).

@Intiroso
Copy link
Author

@Intiroso Intiroso commented Apr 30, 2021

Hexaae, did you try other shortcuts? those one that doesn't work for me for example (Load and Save State, Toggle fullscreen)?.
Fast forward (held and toggle) works in my case too.
Also i was trying randomly some other shortcuts and looks like that most of them work as intended.

Results:
Pause, Frame size (2x to 8x), Bilinear filtering - Work
Reset - Doble press
Frame size 1x - Doesn't even take the gamepad, only keyboard

@Hexaae
Copy link
Contributor

@Hexaae Hexaae commented May 2, 2021

Ok, tested Toggle Fullscreen assigned to LSTICK press (XBox One Bluetooth) and indeed requires 2 presses to work after first press...

@endrift
Copy link
Member

@endrift endrift commented Jun 13, 2021

Sorry for losing track of this; I'd meant to look into and fix this months ago, but it slipped through the cracks until someone else reported it. I did look through the code at some point to see how it could happen though so I did get a head-start on figuring it out.

endrift added a commit that referenced this issue Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants