Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source control bits get cleared when doing a DMA from ROM with a non-incrementing source address #2410

Closed
KellanClark opened this issue Jan 5, 2022 · 0 comments
Labels
platform:GBA Game Boy Advance-related issues
Milestone

Comments

@KellanClark
Copy link

KellanClark commented Jan 5, 2022

Build: 0.9.3
Branch: heads/0.9.3
Revision: 1163869
OS: Linux Mint 64-bit
CPU: Core i7-1065G7
GPU: Intel Iris Plus Graphics

Tested using https://github.com/ICanNotThinkOfAGoodUsername/gbastuff/tree/main/dmacnttest

There is a small issue in the code https://github.com/mgba-emu/mgba/blob/master/src/gba/dma.c#L86-L88 where instead of being ignored and internally treated as increment, the source control bits get physically reset. The value read from DMAxCNT_H after the transfer should remain the same as before (minus the enable bit), but this is not the case as of 0.9.3

Expected:
expected0

Actual:
Screenshot from 2022-01-05 11-49-27

@endrift endrift added the platform:GBA Game Boy Advance-related issues label Jan 7, 2022
@endrift endrift added this to the mGBA 0.10.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:GBA Game Boy Advance-related issues
Projects
None yet
Development

No branches or pull requests

2 participants