Blending with white/black should not be applied to semi-transparent sprites when target 1 excludes sprites and target 2 includes disabled backgrounds

[RidgeX]

Left screenshot is mGBA 0.9.3 with software rendering, right screenshot is NanoBoyAdvance 1.4 (same as hardware). I have attached a test ROM with source code.

blending_test.zip

[exelotl]

I believe I hit the same or a similar bug a while back... in fact I didn't realise it was a bug, and thought it was the other emulators that were doing it wrong 😅

Here's an example:
https://exelo.tl/files/misc/goodboy-blend-demo.gba

mGBA behaviour:

hardware behaviour:

In my code I have:

• set the BLDCNT mode to darkening and opt all layers into both targets
• enable the "blend" effect on a cluster of sprites which form a blue rectangle
• transition BLDY fade value from 16 (fully dark) to 0 (fully visible)
• transition BLDALPHA coefficients from 0:16 (sprites fully transparent) to 12:4 (sprites at around ~80% opacity)

[GValiente]

Another test ROM.

Blending weights can be changed with the keypad.

[endrift]

@exelotl that, if it is a bug (please check on hardware), is unrelated to this bug. This bug is about erroneously taking a disabled background into the blending check.

[endrift]

@GValiente What was that screenshot taken on? It doesn't look like that on mGBA either before or after the fix for the OP issue. If that's how it looks on hardware, it might be the same as exelotl's issue, which is not the same as the OP's issue.

I'm still testing my fix though, just to make sure it doesn't regress anything.

[endrift]

The GL renderer appears to still get this wrong so I'm reopening it until I fix it there too