Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GB] Prehistorik Man seems to have Channels 1 and 2 muted #2614

Closed
CasualPokePlayer opened this issue Aug 8, 2022 · 4 comments
Closed

[GB] Prehistorik Man seems to have Channels 1 and 2 muted #2614

CasualPokePlayer opened this issue Aug 8, 2022 · 4 comments
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Milestone
mGBA 0.10.1

Comments

@CasualPokePlayer
Copy link
Contributor

Tried on 0.9.3 and 519968d. Seems to sound identical to disabling Channels 1 and 2 in bgb.
@endrift
Copy link
Member

endrift commented Aug 9, 2022

Can you see if this worked in previous releases? I swear it worked at some point.

@endrift endrift added platform:GB/GBC Game Boy/Game Boy Color-related issues hardware:audio Issues in the audio subsystem labels Aug 9, 2022
@CasualPokePlayer
Copy link
Contributor Author

Tried 0.8.4, 0.7.3, 0.6.3, all bugged.

@endrift
Copy link
Member

endrift commented Aug 10, 2022

That's probably far enough back, though I suppose there's a chance it worked in 0.5.2. I won't treat it as a regression then.

@endrift endrift added this to the mGBA 0.10.1 milestone Aug 10, 2022
endrift added a commit that referenced this issue Nov 29, 2022
@endrift
GB Audio: Fix channels 1/2 not playing when resetting volume (fixes #…
9f057e2 
…2614)
@endrift
Copy link
Member

endrift commented Nov 29, 2022

This was definitely not a regression. This is really old code. I guess I just misremembered.

rtomasa pushed a commit to rtomasa/mgba that referenced this issue Sep 15, 2023
@endrift @rtomasa
GB Audio: Fix channels 1/2 not playing when resetting volume (fixes m…
65bfd52 
…gba-emu#2614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Projects
None yet
Milestone
mGBA 0.10.1
Development

No branches or pull requests
2 participants
@endrift @CasualPokePlayer