mgba 0.10.0 build failure on apple m1

[chenrui333]

Got some build failure as follows when trying to build on apple m1

  undef: _mSDLGLCreate
  Undefined symbols for architecture arm64:
    "_mSDLGLCreate", referenced from:
        _main in lto.o
  ld: symbol(s) not found for architecture arm64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  make[2]: *** [sdl/mgba] Error 1
  make[1]: *** [sdl/CMakeFiles/mgba-sdl.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

relates to Homebrew/homebrew-core#112961

[endrift]

Please give me your CMakeCache.txt. It builds fine on M1 with the right flags.

[endrift]

It's worth noting that BUILD_GL, the define gating using that function, is forced off if the SDK is 10.14 or newer. Which Includes the M1 SDK. Not really sure how you wound up with it enabled.

[endrift]

I see the problem. You're relying on libepoxy. You shouldn't do that on macOS; that's only needed on Windows.

[chenrui333]

ok, let me give that a try.

[endrift]

If you want to keep epoxy, please test this patch:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ce8e4d687..a8116d3ea 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -718,8 +718,13 @@ if (USE_LZMA)
 endif()
 
 if(USE_EPOXY)
-	list(APPEND FEATURE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/src/platform/opengl/gl.c ${CMAKE_CURRENT_SOURCE_DIR}/src/platform/opengl/gles2.c)
-	list(APPEND FEATURE_DEFINES BUILD_GL BUILD_GLES2 BUILD_GLES3)
+	if(APPLE AND MACOSX_SDK VERSION_GREATER 10.14)
+		list(APPEND FEATURE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/src/platform/opengl/gles2.c)
+		list(APPEND FEATURE_DEFINES BUILD_GLES2 BUILD_GLES3)
+	else()
+		list(APPEND FEATURE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/src/platform/opengl/gl.c ${CMAKE_CURRENT_SOURCE_DIR}/src/platform/opengl/gles2.c)
+		list(APPEND FEATURE_DEFINES BUILD_GL BUILD_GLES2 BUILD_GLES3)
+	endif()
 	list(APPEND FEATURES EPOXY)
 	include_directories(AFTER ${EPOXY_INCLUDE_DIRS})
 	link_directories(${EPOXY_LIBRARY_DIRS})

which I will commit upstream if it works.

[chenrui333]

yeah, that build patch works for me, I also added the lua and libelf dependencies

[endrift]

I'll commit a variant of it then. Gimme a sec.

[endrift]

I've cherry-picked the patch into 0.10.1, so it'll be in the next stable release.

[chenrui333]

Sounds good, thanks!