Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBA Multiboot ROMs Do Not Have BIOS Force Skipped #2753

Closed
CasualPokePlayer opened this issue Dec 13, 2022 · 1 comment · Fixed by #2754
Closed

GBA Multiboot ROMs Do Not Have BIOS Force Skipped #2753

CasualPokePlayer opened this issue Dec 13, 2022 · 1 comment · Fixed by #2754

Comments

@CasualPokePlayer
Copy link
Contributor

Buggy code is here:

mgba/src/gba/core.c

Line 703 in 694b80d

bool forceSkip = gba->romVf && GBAIsMB(gba->romVf);

MB is held in gba->mbVf rather than gba->romVf, so gba->romVf will just be null.
CasualPokePlayer added a commit to CasualPokePlayer/mgba that referenced this issue Dec 13, 2022
@CasualPokePlayer
Check gba->mbVf for force skipping the BIOS
7ae1691 
Resolves mgba-emu#2753
@CasualPokePlayer CasualPokePlayer mentioned this issue Dec 13, 2022
Merged
@endrift
Copy link
Member

endrift commented Dec 17, 2022

If this is present in 0.10.0, you should add a changelog entry.

@endrift endrift mentioned this issue Jan 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check gba->mbVf for force skipping the BIOS CasualPokePlayer/mgba
2 participants
@endrift @CasualPokePlayer