-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMG envelop change without retriggering sounds wrong #3067
Comments
Almost forgot. I wanted to mention that this specific regression also exists on DS and 3DS GBA hardware since it's not documented anywhere. So technically it's accurate emulation just not of GBA/GBA SP behavior. GB micro is unknown/untested. |
I must add that this works correctly in GBmicro, so only the DS/3DS GBA hardware modes have this bug. |
The problem might be that It's kinda peculiar that mgba has the same bug as ds and 3ds hw btw. |
I'm unsure this change is correct, but I'll do a bit more in-depth checking later. I'm not 100% sure how writing to the envelope on an active channel works, but generally it's understood to be "buggy" |
Good to know the GB micro is unaffected. |
In the hardware, the envelop starts as expected, but in mGBA the envelop never starts.
Hardware -> mGBA recording
hardware_mgba.mp4
Test ROM
F0_F7_no_retrig.zip
Code
The text was updated successfully, but these errors were encountered: