New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lady Sia blue line, I want to help #744

Closed
meepingsnesroms opened this Issue May 30, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@meepingsnesroms

meepingsnesroms commented May 30, 2017

My email address is guicrith@insiberia.net and I would like to work on this bug.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift May 30, 2017

Member

Good luck.

Member

endrift commented May 30, 2017

Good luck.

@meepingsnesroms

This comment has been minimized.

Show comment
Hide comment
@meepingsnesroms

meepingsnesroms May 30, 2017

Wow, quick response, could I please have your existing save state so I dont have to play through the whole game and whatever else that might help. (disassembly, sram file).

meepingsnesroms commented May 30, 2017

Wow, quick response, could I please have your existing save state so I dont have to play through the whole game and whatever else that might help. (disassembly, sram file).

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift May 30, 2017

Member

Here's a save file: lady-sia.zip It's easy to get to the level from here.

Member

endrift commented May 30, 2017

Here's a save file: lady-sia.zip It's easy to get to the level from here.

@meepingsnesroms

This comment has been minimized.

Show comment
Hide comment
@meepingsnesroms

meepingsnesroms May 31, 2017

I found something that is wrong, BG1VOFS goes up to 295 when the bg1 size is set to 256x256

meepingsnesroms commented May 31, 2017

I found something that is wrong, BG1VOFS goes up to 295 when the bg1 size is set to 256x256

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift May 31, 2017

Member

That value almost certainly wraps...

Member

endrift commented May 31, 2017

That value almost certainly wraps...

@meepingsnesroms

This comment has been minimized.

Show comment
Hide comment
@meepingsnesroms

meepingsnesroms May 31, 2017

To where, x can wraparound to y + 1 but this is on the y axis.
Are you saying that the gba does this:
if(BG1VOFS > max_y){
BG1VOFS = BG1VOFS % max_y;
}

But in hardware?

meepingsnesroms commented May 31, 2017

To where, x can wraparound to y + 1 but this is on the y axis.
Are you saying that the gba does this:
if(BG1VOFS > max_y){
BG1VOFS = BG1VOFS % max_y;
}

But in hardware?

@zeromus

This comment has been minimized.

Show comment
Hide comment
@zeromus

zeromus May 31, 2017

The hardware does bg_line = (vofs+scanline)%max_y
You need to read a basic tutorial on scanline based tile engine rendering before you can help here.

zeromus commented May 31, 2017

The hardware does bg_line = (vofs+scanline)%max_y
You need to read a basic tutorial on scanline based tile engine rendering before you can help here.

@meepingsnesroms

This comment has been minimized.

Show comment
Hide comment
@meepingsnesroms

meepingsnesroms May 31, 2017

Is an HLE patch ok, like adding +=3 to the bg1 start line in that level?
This would patch the ROM on launch with the new offset, not check what game it is every frame.
I am asking because I know some may not want this in there emulator.

meepingsnesroms commented May 31, 2017

Is an HLE patch ok, like adding +=3 to the bg1 start line in that level?
This would patch the ROM on launch with the new offset, not check what game it is every frame.
I am asking because I know some may not want this in there emulator.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift May 31, 2017

Member

That's called a "game specific hack" and it's absolutely not acceptable.

Member

endrift commented May 31, 2017

That's called a "game specific hack" and it's absolutely not acceptable.

@meepingsnesroms

This comment has been minimized.

Show comment
Hide comment
@meepingsnesroms

meepingsnesroms May 31, 2017

Do you know if this happens on the GBMicro, DS, DS lite or revok101?
Sorry for asking so much but I have no testing hardware.(Not even a gba)
I do have a DSLite but lack a GBA flash cart.

I think it is caused by audio being slightly faster here than on a GBA so it switches before it reaches the proper scanline.

meepingsnesroms commented May 31, 2017

Do you know if this happens on the GBMicro, DS, DS lite or revok101?
Sorry for asking so much but I have no testing hardware.(Not even a gba)
I do have a DSLite but lack a GBA flash cart.

I think it is caused by audio being slightly faster here than on a GBA so it switches before it reaches the proper scanline.

@endrift endrift closed this in 7fd3eb7 Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment