Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upLoad New Shader default path #767
Comments
This comment has been minimized.
This comment has been minimized.
Strange. It works fine on macOS. |
endrift
added
severity:minor bug
port:Qt
feature:usability
labels
Jun 30, 2017
This comment has been minimized.
This comment has been minimized.
endrift
modified the milestone:
0.6.0
Jun 30, 2017
This comment has been minimized.
This comment has been minimized.
I'm not at my Linux computer at the moment, but see if this patch fixes it (and make sure a .deb that's generated puts the .desktop in the right place): diff --git a/src/platform/qt/CMakeLists.txt b/src/platform/qt/CMakeLists.txt
index 088e26d..a41e422 100644
--- a/src/platform/qt/CMakeLists.txt
+++ b/src/platform/qt/CMakeLists.txt
@@ -209,7 +209,7 @@ if(NOT DEFINED DATADIR)
if(APPLE)
set(DATADIR Applications/${PROJECT_NAME}.app/Contents/Resources)
else()
- set(DATADIR ${CMAKE_INSTALL_DATADIR}/${BINARY_NAME})
+ set(DATADIR ${CMAKE_INSTALL_FULL_DATADIR}/${BINARY_NAME})
endif()
endif()
install(DIRECTORY ${CMAKE_SOURCE_DIR}/res/shaders DESTINATION ${DATADIR} COMPONENT ${BINARY_NAME}-qt)
@@ -253,7 +253,7 @@ install(TARGETS ${BINARY_NAME}-qt
if(UNIX AND NOT APPLE)
find_program(DESKTOP_FILE_INSTALL desktop-file-install)
if(DESKTOP_FILE_INSTALL)
- install(CODE "execute_process(COMMAND ${DESKTOP_FILE_INSTALL} \"${CMAKE_SOURCE_DIR}/res/mgba-qt.desktop\" --dir \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATADIR}/applications/\")")
+ install(CODE "execute_process(COMMAND ${DESKTOP_FILE_INSTALL} \"${CMAKE_SOURCE_DIR}/res/mgba-qt.desktop\" --dir \"\$ENV{DESTDIR}\${CMAKE_INSTALL_FULL_DATADIR}/applications/\")")
endif()
endif()
if(UNIX) |
This comment has been minimized.
This comment has been minimized.
that appears when you press the Load New Shader button |
This comment has been minimized.
This comment has been minimized.
noabody
commented
Jul 8, 2017
With my daily build on Ubuntu 17.04 64-bit I also cannot load a shader. All folders are "greyed out" not selectable. This behaviour is not present on the win32 version in wine. That works properly. Adding the name of the shader folder to the "shader=" line works fine. |
This comment has been minimized.
This comment has been minimized.
Yeah I have a fix for this that I haven't committed yet. |
endrift
closed this
in
ecc4d6e
Jul 8, 2017
added a commit
that referenced
this issue
Jul 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiobenrocha2 commentedJun 30, 2017
•
edited
seems "Load New Shader" default path is the ROM path, it should be /usr/share/mgba/shaders/ on linux for example
ubuntu 17.04